-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable select some e2e cases to run or skip some cases #638
Conversation
Signed-off-by: YaoZengzeng <[email protected]>
Signed-off-by: YaoZengzeng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
test/e2e/run_test.sh
Outdated
go test -v -tags=integ $ROOT_DIR/test/e2e/... -count=1 | ||
cmd="go test -v -tags=integ $ROOT_DIR/test/e2e/... -count=1 $PARAMS" | ||
|
||
eval $cmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: no need to use eval and -count=1 can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"-count=1" is to disable go test cache. Enabling it by default is more convenient for local debugging and developing of e2e test cases. For CI, since it runs from scratch and only run once, it has no effect.
Signed-off-by: YaoZengzeng <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Add two flags to E2E framework:
--select-cases: select some cases to run
--skip-cases: skip some cases and run others
Which issue(s) this PR fixes:
Fixes #523
Special notes for your reviewer:
Does this PR introduce a user-facing change?: